-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Implement steps() timing function editor #5799
Conversation
@larz0 Here is the steps() function code. |
Nominating for Sprint 35 |
@larz0 This pull request was nominated for Sprint 35. Can you take a look and respond with what you think needs to be done to this feature for it to get into master? Then we can figure out if we can get it done this sprint. |
@redmunds ok I'll take a look this afternoon. |
@larz0 I added some info text for both the cubic-bezier and steps editors. Let me know what you think. It's going to be a fair amount of work to display error messages (need separate test and string for every possible error), so I want to make sure this is on the right track before proceeding. If it's OK, then feel free to tweak position, styles, text, etc. |
@larz0 I thought you asked me to add symbols for arrow keys to the info text (but I can't seem to find your comment), so I added those. I looked for unicode symbols for mouse click and drag operations, but couldn't find anything -- I suppose we could use images. Let me know what else you think needs to be done to merge this into master. In the spirit of agile, maybe we should merge what we have and listen for feedback? |
I like that! Is that format used anywhere else in Brackets so I could re-use the boxes and background-color? I also added info text to cubic-bezier() editor, so that's why I was asking about mouse click and drag. Suggestions? |
Awesome. I'll make those changes in cubic-bezier as well. I'm going to remove "Bezier curve endpoints can be dragged with mouse." because it's pretty clear that they can be dragged as they look like typical bezier curve handles. |
@redmunds I've made the changes, might want to take a look just in case. |
Looks awesome! Let me know when you're happy with XD side, and I'll get a dev to give this a code review. |
@redmunds I'm happy with XD side. Let's try and merge this :) |
XD review is complete. Ready for Dev code review. |
@@ -477,6 +477,8 @@ define({ | |||
// extensions/default/InlineTimingFunctionEditor | |||
"INLINE_TIMING_EDITOR_TIME" : "Time", | |||
"INLINE_TIMING_EDITOR_PROGRESSION" : "Progression", | |||
"BEZIER_EDITOR_INFO" : "<kbd>↑</kbd><kbd>↓</kbd><kbd>←</kbd><kbd>→</kbd> Move selected point<br><kbd class='text'>Shift</kbd> Move by ten units", | |||
"STEPS_EDITOR_INFO" : "<kbd>↑</kbd><kbd>↓</kbd> Increase or decrease steps.<br><kbd>←</kbd><kbd>→</kbd> 'Start' or 'End'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After steps
there is a period, but in the other 3 cases of "end of line" there isn't.
These should be standardized.
Done with code review. Looks and works great! merging. |
Implement steps() timing function editor
Support for:
Keyboard Events
Mouse support
Issues?